Remove dead Bignum availability guards from tests#197
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
Crypt::OpenSSL::Bignum is a hard compile-time dependency via `use Crypt::OpenSSL::Bignum` in RSA.pm. The t/fakelib/ mock and all $HAS_BIGNUM / skip_all checks in tests are dead code — they can never trigger because RSA.pm won't compile without the real Bignum module. - Remove t/fakelib/ (mock Bignum that returns false) - Remove dead skip_all in bignum.t and check_param.t - Remove $HAS_BIGNUM variable and SKIP guards in keygen.t and key_lifecycle.t Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t/fakelib/(mock Bignum that returns false — dead sinceuse Crypt::OpenSSL::Bignumin RSA.pm)skip_all/$HAS_BIGNUMguards in bignum.t, check_param.t, keygen.t, key_lifecycle.tWhy
Crypt::OpenSSL::Bignumis a hard compile-time dependency (useon line 7 of RSA.pm). The fakelib mock and all Bignum-availability checks in test files are dead code — they can never trigger because RSA.pm won't compile without the real module. These guards mislead readers into thinking Bignum is optional.Testing
Full test suite passes (666 tests across 23 files). Kwalitee checks pass with updated MANIFEST.
🤖 Generated with Claude Code
Quality Report
Changes: 6 files changed, 7 insertions(+), 33 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline